dbeaver/pro#8486 feat: add DataReadonlyReason API for data sources#4354
Merged
serge-rider merged 4 commits intoMay 25, 2026
Merged
Conversation
Previously TableStatusIndicator relied on model.isReadonly() which lost reasons. This caused the "Read-only connection" tooltip to show in grouping panel even on editable connections — the connection wasn't read-only, the presentation was. Each data source now declares its specific reason via getReadonlyReason(). UI maps the typed reason to an accurate message
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
sergeyteleshev
previously approved these changes
May 21, 2026
devnaumov
reviewed
May 21, 2026
| Default, | ||
| Readonly, | ||
| } | ||
| export enum DataReadonlyReason { |
Member
There was a problem hiding this comment.
Let’s try using DatabaseDataFeature to determine the model’s read-only reason (Grouping). This will allow us to keep the logic inside TableStatusIndicator, which is the only place where it’s needed.
…se hasFeature flag
devnaumov
approved these changes
May 24, 2026
serge-rider
deleted the
8486-cb-wrong-tooltip-for-the-table-type-in-some-panels
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously TableStatusIndicator relied on model.isReadonly() which lost reasons. This caused the "Read-only connection" tooltip to show in grouping panel even on editable connections — the connection wasn't read-only, the presentation was.
Each data source now declares its specific reason via getReadonlyReason(). UI maps the typed reason to an accurate message